Skip to content

Fix SIGKILL in CI#5292

Draft
jdetter wants to merge 5 commits into
rekhoff/nativeaot-net10from
jdetter/fix-sig-kill
Draft

Fix SIGKILL in CI#5292
jdetter wants to merge 5 commits into
rekhoff/nativeaot-net10from
jdetter/fix-sig-kill

Conversation

@jdetter

@jdetter jdetter commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Description of Changes

API and ABI breaking changes

Expected complexity level and risk

Testing

@jdetter jdetter marked this pull request as draft June 12, 2026 14:58
@jdetter jdetter changed the base branch from master to rekhoff/nativeaot-net10 June 12, 2026 14:58
joshua-spacetime and others added 3 commits June 16, 2026 14:30
# Description of Changes

Fixes an OOM kill in the proptest `bsatn_invalid_wont_decode`.

`bsatn_invalid_wont_decode` generates arbitrary invalid bytes, proves
validation fails, then still calls full AlgebraicValue::decode. For
generated array-like types, decode reads a u32 length prefix, and the
generic array visitor then reserves that capacity. But because they're
random bytes, this could cause a huge initial allocation which could OOM
kill the test process.

Now the visitor reserves a smaller initial capacity instead of assuming
the binary input data is well formed.

# API and ABI breaking changes

N/A

# Expected complexity level and risk

1

# Testing

This should fix the flaky `spacetimedb-sats` `Test Suite` failures that
occasionally end in a SIGKILL.
@jdetter jdetter force-pushed the jdetter/fix-sig-kill branch from ab66cca to abe443f Compare June 16, 2026 16:33
@lisandroct lisandroct force-pushed the rekhoff/nativeaot-net10 branch from c1c3e94 to 5f10d9e Compare June 16, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants